Open
Conversation
…ure and extend tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New feature to accelerate the resampling with CPU based parallelization.
The parallelization is realized by a call to
parallel::mclapplyinstead of the previouslapply.To get safe parallel random numbers, the RNG is replaced by the L'Ecuyer-CMRG generator, while the initial RNG is stored and reset after the resampling.
This feature breakes the interface of the
GOF_model_testclass constructor, which now requires two additional parametersn_coresandseed, which are required to set the degree of parallelization and seed the internally setup RNG.These parameters are also new to the
GOF_modelmain function (which are simply passed to the test class), using default values however.There is a new section in the README explaining a bit about the parallelization with a short example.